-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#886) Add support for more arguments in packages.config #2504
Merged
gep13
merged 1 commit into
chocolatey:develop
from
TheCakeIsNaOH:packages-config-all-options
Aug 11, 2022
Merged
(#886) Add support for more arguments in packages.config #2504
gep13
merged 1 commit into
chocolatey:develop
from
TheCakeIsNaOH:packages-config-all-options
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three big todos left on this:
|
7 tasks
TheCakeIsNaOH
force-pushed
the
packages-config-all-options
branch
from
March 6, 2022 05:11
afbad9f
to
75617fd
Compare
TheCakeIsNaOH
force-pushed
the
packages-config-all-options
branch
from
March 9, 2022 16:29
75617fd
to
ee32006
Compare
TheCakeIsNaOH
force-pushed
the
packages-config-all-options
branch
from
March 21, 2022 16:14
ee32006
to
8511938
Compare
TheCakeIsNaOH
force-pushed
the
packages-config-all-options
branch
from
June 27, 2022 15:15
8511938
to
2e400c9
Compare
gep13
force-pushed
the
packages-config-all-options
branch
from
August 11, 2022 20:41
2e400c9
to
d9eb80a
Compare
This adds the remaining arguments in the install command's OptionSet as elements to the packages.config xml serialization schema. This is useful for users wanting arguments that were previously not available. It is also a pre-requisite for exporting remembered arguments, as some of the remembered arguments were not available in the previous available schema.
gep13
force-pushed
the
packages-config-all-options
branch
from
August 11, 2022 20:52
d9eb80a
to
35d9254
Compare
gep13
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@TheCakeIsNaOH this looks amazing! Thank you for getting all of these added! I will get this merged once the CI builds finish up. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds the remaining arguments in the install command's OptionSet and some more arguments in the global OptionSet as elements to the packages.config xml serialization schema.
Motivation and Context
This is useful for users wanting arguments that were previously not
available. It is also a pre-requisite for exporting remembered
arguments, as some of the remembered arguments were not available
in the previous available schema.
Some of the global arguments were not added:
All of these appeared to either not be applicable to a single package (e.g. proxy related) or required earlier than the packages.config would get read (like log-file).
Testing
Save this as a packages.config file:
Set the debugging arguments as
install \path\to\packages.config
Then set a breakpoint at
get_packages_from_config
inChocolateyPackageService
, and step through the method, ensuring that the settings in thepackageConfig
get updated correctly.Change Types Made
Related Issue
Fixes #886
Depends on #2187
Change Checklist